| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kashif Zeeshan <kashif(dot)zeeshan(at)enterprisedb(dot)com> |
| Cc: | Rajkumar Raghuwanshi <rajkumar(dot)raghuwanshi(at)enterprisedb(dot)com>, Ahsan Hadi <ahsan(dot)hadi(at)gmail(dot)com>, Asif Rehman <asifr(dot)rehman(at)gmail(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP/PoC for parallel backup |
| Date: | 2020-04-02 14:20:15 |
| Message-ID: | CA+TgmoZC0r6CeStjEV9z=axTmH-d+mXX2qRUkTwoSWSs6HS_hw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 2, 2020 at 9:46 AM Kashif Zeeshan <
kashif(dot)zeeshan(at)enterprisedb(dot)com> wrote:
> Does it fail to clean up the backup folder in all cases where the
>> backup failed, or just in this case?
>>
> The cleanup is done in the cases I have seen so far with base
> pg_basebackup functionality (not including the parallel backup feature)
> with the message "pg_basebackup: removing contents of data directory"
> A similar case was also fixed for parallel backup reported by Rajkumar
> where the contents of the backup folder were not cleaned up after the error.
>
What I'm saying is that it's unclear whether there's a bug here or whether
it just failed because of the very extreme test scenario you created.
Spawning >1000 processes on a small machine can easily make a lot of things
fail.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2020-04-02 14:36:38 | Re: WAL usage calculation patch |
| Previous Message | Fabien COELHO | 2020-04-02 13:58:50 | Re: pgbench - add \aset to store results of a combined query |