Re: [PATCH] add option to pg_dumpall to exclude tables from the dump

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Gerdan Rezende dos Santos <gerdan(at)gmail(dot)com>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Juergen Hannappel <juergen(at)juergen-hannappel(dot)de>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] add option to pg_dumpall to exclude tables from the dump
Date: 2016-09-28 17:16:26
Message-ID: CA+TgmoZBfKV_74TFCydMs1gPv9Znh2NvC5PVOHiOf0ivD6o3+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 6, 2016 at 9:37 PM, Gerdan Rezende dos Santos
<gerdan(at)gmail(dot)com> wrote:
> After review, I realized that there is a call to the function:
> doShellQuoting (pgdumpopts, OPTARG), which no longer seems to exist ...
> After understand the code, I saw that the call is appendShellString
> (pgdumpopts, OPTARG).
>
> Follow the patches already with the necessary corrections.

This doesn't seem to take into account the discussion between Tom Lane
and Jim Nasby about how this feature should work.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2016-09-28 17:19:00 Re: Truncating/vacuuming relations on full tablespaces
Previous Message Magnus Hagander 2016-09-28 17:15:05 Re: pg_basebackup stream xlog to tar