| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: RFC: extensible planner state |
| Date: | 2025-08-20 19:13:51 |
| Message-ID: | CA+TgmoZ3mOt=op-wONtUULthM_ViJ5nrswuDh_01_oB2yxVSGA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 19, 2025 at 2:28 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> You'll presumably have to use GetMemoryChunkContext() for RelOptInfo,
> so I don't see much downside from using it in one or even both of the
> other cases too.
Pointer dereference must be faster than a function call.
> Hm. We don't have read support for these structs, so maybe it's fine.
> It looks weird though.
Left this one as-is for now.
Here's v2. 0001 is what you saw before with an attempt to fix the
memory context handling. 0002 removes join_search_private. All I've
tested is that the tests pass.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-Remove-PlannerInfo-s-join_search_private-method.patch | application/octet-stream | 8.6 KB |
| v2-0001-Allow-private-state-in-certain-planner-data-struc.patch | application/octet-stream | 10.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2025-08-20 19:19:43 | Re: Don't treat virtual generated columns as missing statistics in vacuumdb --missing-stats-only |
| Previous Message | Kirk Wolak | 2025-08-20 19:09:28 | Re: Retail DDL |