From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
---|---|
To: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_stat_replication vs StandbyReplyMessage |
Date: | 2011-08-16 13:25:37 |
Message-ID: | CA+TgmoZ39FvwbVQGAusNx_Mv=yqOr_UFuFnMorNYNvxPaxkOeA@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Tue, Aug 16, 2011 at 8:54 AM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
> On Tue, Aug 16, 2011 at 10:51 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>> On Mon, Aug 15, 2011 at 13:50, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> On Mon, Aug 15, 2011 at 7:03 AM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>>>> The pg_stat_replication view exposes all the fields in
>>>> StandbyReplyMessage *except* for the timestamp when the message was
>>>> generated. On an active system this is not all that interesting, but
>>>> on a mostly idle system that allows the monitoring to react faster
>>>> than the timeout that actually kicks the other end off - and could be
>>>> useful in manual debugging scenarios. Any particular reason why this
>>>> was not exposed as it's own column?
>>>
>>> I wondered the same thing. Sounds like a good idea.
>>
>> I can go do that. Care to argue^Wbikeshed for a specific name?
>
> reply_timestamp
Works for me. I'd suggest that we rename it that way in
StandbyReplyMessage, so that the name in the struct and the name in
the system view match.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | David Fetter | 2011-08-16 13:33:26 | Re: pgsql: In pg_upgrade, avoid dumping orphaned temporary tables. This ma |
Previous Message | Simon Riggs | 2011-08-16 13:25:15 | Re: Some problems about cascading replication |