Re: fix typos

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Erik Rijkers <er(at)xs4all(dot)nl>
Cc: John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Bruce Momjian <bruce(at)momjian(dot)us>
Subject: Re: fix typos
Date: 2022-08-03 16:41:33
Message-ID: CA+TgmoZ1QvHquYHLkMy1oHKqz4-E7QQctj6e0ocq_GP1B5+9bA@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 2, 2022 at 4:32 AM Erik Rijkers <er(at)xs4all(dot)nl> wrote:
> > The part of the sentence inside parentheses is not clear to me, before
> > or after the patch:
> >
> > Dropping an extension causes its component objects, and other
> > explicitly
> > dependent routines (see <xref linkend="sql-alterroutine"/>,
> > - the depends on extension action), to be dropped as well.
> > + that depend on extension action), to be dropped as well.
> > </para>
> >
>
> Hm, I see what you mean, I did not notice that earlier and I won't make
> a guess as to intention. Maybe Bruce can have another look? (commit
> 5fe2d4c56e)

I think that it's talking about this (documented) syntax:

ALTER ROUTINE name [ ( [ [ argmode ] [ argname ] argtype [, ...] ] ) ]
[ NO ] DEPENDS ON EXTENSION extension_name

So the change from "depends" to "depend" here is incorrect. Maybe we
can say something like:

the <literal>DEPENDS ON EXTENSION
<replaceable>extension_name</replaceable><literal> action

(I haven't tested whether this markup works.)

--
Robert Haas
EDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2022-08-03 16:42:05 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Previous Message Nathan Bossart 2022-08-03 16:16:28 Re: support for SSE2 intrinsics