| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: tuplesort Generation memory contexts don't play nicely with index builds |
| Date: | 2022-07-06 21:49:43 |
| Message-ID: | CA+TgmoZ=z2g3d8Rxu3uiZYoi6J3KdeJhWCVs81dGGhkYfD9Yiw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Jul 5, 2022 at 9:34 PM David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> I voiced my dislike for the patch I came up with to fix this issue to
> Andres. He suggested that I just add a version of index_form_tuple
> that can be given a MemoryContext pointer to allocate the returned
> tuple into.
>
> I like that idea much better, so I've attached a patch to fix it that way.
>
> If there are no objections, I plan to push this in the next 24 hours.
Apologies for not having looked at this thread sooner, but for what
it's worth, I think this is a fine solution.
Thanks,
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-07-06 22:07:46 | Re: BUG #17540: Prepared statement: PG switches to a generic query plan which is consistently much slower |
| Previous Message | Tom Lane | 2022-07-06 21:46:27 | Re: automatically generating node support functions |