Re: [v9.2] make_greater_string() does not return a string in some cases

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)oss(dot)ntt(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [v9.2] make_greater_string() does not return a string in some cases
Date: 2011-10-18 13:32:24
Message-ID: CA+TgmoZ+3gv=x7ScvFbJgE4pywRfy8QQ=ymDvKoRoWxVDGPWjQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Tue, Oct 18, 2011 at 12:11 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Mon, Oct 17, 2011 at 11:54 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> http://www.faqs.org/rfcs/rfc3629.html
>
>> I'm still confused.  The input string is already known to be valid
>> UTF-8, so the second byte (if there is one) must be between 0x80 and
>> 0xBF.  Therefore it will be neither 0xED nor 0xF4.
>
> I haven't read the patch lately, but ED and F4 are special as *first*
> bytes.  Maybe the logic isn't quite right, or you read it wrong?

I think I'll let the patch author comment on that. It looks wrong to
me, but I just work here.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Susanne Ebrecht 2011-10-18 14:38:37 Re: char(0)
Previous Message Robert Young 2011-10-18 10:03:39 incompatible pointer type

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-10-18 13:36:50 Re: new compiler warnings
Previous Message Tom Lane 2011-10-18 13:32:15 Re: new compiler warnings