| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: non-exclusive backup cleanup is mildly broken |
| Date: | 2019-12-18 12:43:43 |
| Message-ID: | CA+TgmoYxnjL43p-_x+Bq60uPXJ1Z43k0pSwcnhzzOzJ5T5FjwQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 17, 2019 at 11:36 PM Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> If pg_abort_backup callback function can be called safely even when
> the backup is not in progress, we can just use the global variable like
> pg_abort_backup_registered to register the callback function only
> on first call. In this way, cancel_before_shmem_exit() doesn't need to
> search the array to get rid of the function.
Right. That's how the proposed patch works.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Prabhat Sahu | 2019-12-18 12:57:18 | Re: [HACKERS] Block level parallel vacuum |
| Previous Message | Amit Kapila | 2019-12-18 12:34:42 | Re: [HACKERS] Block level parallel vacuum |