| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Rearm statement_timeout after each executed query. |
| Date: | 2018-02-09 20:50:44 |
| Message-ID: | CA+TgmoYwf05jVpKXDVjejr_=gkRh+iDVM2a0QapRx8vTZN7DRQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Feb 7, 2018 at 7:04 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> On Tue, Feb 6, 2018 at 5:21 PM, Peter Eisentraut
> <peter(dot)eisentraut(at)2ndquadrant(dot)com> wrote:
>> On 9/18/17 22:41, Andres Freund wrote:
>>> Rearm statement_timeout after each executed query.
>>
>> This appears to have broken statement_timeout behavior in master such
>> that only every second query is affected by it.
>
> Yeah, I also just ran into this while testing a nearby complaint about
> statement timeouts vs parallel query. In the error path
> stmt_timeout_active remains true, so the next statement does nothing
> in enable_statement_timeout(). I think we just need to clear that
> flag in the error path, right where we call disable_all_timeouts().
> See attached.
Looks right. Committed, but I thought the comment was strange (forget
about?) so I just left that out.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-02-09 21:01:32 | pgsql: Mark assorted GUC variables as PGDLLIMPORT. |
| Previous Message | Robert Haas | 2018-02-09 20:50:42 | pgsql: Clear stmt_timeout_active if we disable_all_timeouts. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-02-09 21:01:35 | Re: Add PGDLLIMPORT to enable_hashagg |
| Previous Message | mxbi | 2018-02-09 20:48:58 | Re: configure issue - warnings sort: No such file or directory |