| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: tab completion for partitioning |
| Date: | 2017-02-26 17:25:21 |
| Message-ID: | CA+TgmoYwWiFCaEcG3+L5NYO_U=Ur1FNy7cdMSK_KMqaovga0yA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 20, 2017 at 8:37 AM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> Thanks for taking a look. Hm, I think the second part seems to be
> needless duplication. So, I changed it to match using TailMatches2("FOR",
> "VALUES") and kept just one instance of it. The first part is matching
> and completing two different commands (ATTACH PARTITION partition_name and
> PARTITION OF parent_name), so that seems fine.
I agree. Committed this version.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-26 17:26:25 | Re: Parallel Append implementation |
| Previous Message | Michael Banck | 2017-02-26 17:21:53 | Re: [patch] reorder tablespaces in basebackup tar stream for backup_label |