Re: clog double-dip in heap_hot_search_buffer

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: clog double-dip in heap_hot_search_buffer
Date: 2012-05-02 16:07:55
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

On Wed, May 2, 2012 at 12:06 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> +     /* Deleter committed, so tuple is alive if the XID is old enough. */
>> +     return TransactionIdPrecedes(HeapTupleHeaderGetXmax(tuple), OldestXmin);
> s/alive/dead/ in that comment?

Yep, good catch, thanks.

> Otherwise this seems like a good idea.

Do you think I should apply this to 9.2, or wait until 9.3?

Robert Haas
The Enterprise PostgreSQL Company

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2012-05-02 16:15:38 Re: Temporary tables under hot standby
Previous Message Tom Lane 2012-05-02 16:06:43 Re: clog double-dip in heap_hot_search_buffer