Re: Errands around AllocateDir()

On Mon, Dec 4, 2017 at 12:05 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Michael Paquier <michael(dot)paquier(at)gmail(dot)com> writes:
>> I had a close look at all the callers of AllocateDir() and noticed a
>> couple of unwelcome things (Tom noticed some of those in the thread
>> mentioned above, I found others):
>
> The only part of this that seems likely to be controversial is the
> decision to get rid of special-case error messages, eg replace
> "could not open tablespace directory \"%s\": %m"
> with the more generic
> "could not open directory \"%s\": %m"
>
> As I said in the previous thread, I don't see anything much wrong
> with that; but if anyone doesn't like it, speak now.

I find that change an improvement, but not something to back-patch.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company