Re: map_partition_varattnos() and whole-row vars

On Fri, Jul 28, 2017 at 1:06 AM, Noah Misch <noah(at)leadboat(dot)com> wrote:
> [Action required within three days. This is a generic notification.]
>
> The above-described topic is currently a PostgreSQL 10 open item. Robert,
> since you committed the patch believed to have created it, you own this open
> item. If some other commit is more relevant or if this does not belong as a
> v10 open item, please let us know. Otherwise, please observe the policy on
> open item ownership[1] and send a status update within three calendar days of
> this message. Include a date for your subsequent status update. Testers may
> discover new open items at any time, and I want to plan to get them all fixed
> well in advance of shipping v10. Consequently, I will appreciate your efforts
> toward speedy resolution. Thanks.

I'll try to get this resolved by the end of next week, but I don't
know if that will be possible. I don't completely understand the
issue yet.

If we're remapping the varattnos, I don't see how we can just pass
whole-row references through. I mean, if the partition and the parent
have different varattnos, then a whole-row attribute for one is a
different thing from a whole-row attribute for the other; the
HeapTuple you would need to build in each case is different, based on
the column order for the relation you're worrying about.

(Boy, our implementation of DROP COLUMN is painful! If we really got
rid of columns when they were dropped we could've avoided this whole
mess.)

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company