| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Bogus EPQ plan construction in postgres_fdw |
| Date: | 2018-12-14 22:07:00 |
| Message-ID: | CA+TgmoYp0hqiW=EK+=T+u37AQn=qB-kknoO+n4xkuT9C1x4ukA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Dec 12, 2018 at 8:00 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> By chance I noticed that postgres_fdw's postgresGetForeignPlan() assumes
> --- without any checking --- that the outer_plan it's given for a join
> relation must have a NestLoop, MergeJoin, or HashJoin node at the top.
> That's been wrong at least since commit 4bbf6edfb (which could cause
> insertion of a Sort node on top) and it seems like a pretty unsafe
> thing to Just Assume even without that.
Thanks for taking care of this. I've looked at this code any number
of times and never quite noticed the assumption that outer_plan had to
be a join.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-12-14 22:24:34 | Re: 'infinity'::Interval should be added |
| Previous Message | John Naylor | 2018-12-14 21:40:08 | Re: Speeding up text_position_next with multibyte encodings |