Re: Making tab-complete.c easier to maintain

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Making tab-complete.c easier to maintain
Date: 2015-10-22 21:29:51
Message-ID: CA+TgmoYow9qMFJ8hJipmd7K9=_xeUtAVVarQJGY401_nTnopeQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Oct 21, 2015 at 8:54 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> Here is a new version merging the recent CREATE EXTENSION ... VERSION
> patch from master.
>
> (Apologies for sending so many versions. tab-complete.c keeps moving
> and I want to keep a version that applies on top of master out there,
> for anyone interested in looking at this. As long as no one objects
> and there is interest in the patch, I'll keep doing that.)

I don't want to rain on the parade since other people seem to like
this, but I'm sort of unimpressed by this. Yes, it removes >1000
lines of code, and that's not nothing. But it's all mechanical code,
so, not to be dismissive, but who really cares? Is it really worth
replacing the existing notation that we all know with a new one that
we have to learn? I'm not violently opposed if someone else wants to
commit this, but I'm unexcited about it.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-10-22 21:34:38 Avoid full page images in streaming replication?
Previous Message Robert Haas 2015-10-22 21:18:50 Re: Change behavior of (m)xid_age