| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers(at)postgresql(dot)org, rmt(at)lists(dot)postgresql(dot)org |
| Subject: | Re: PGQ catalog representation and pg_dump support |
| Date: | 2026-09-16 20:47:31 |
| Message-ID: | CA+TgmoYkyXSkParQXSemQ0Vdh2HZ5HVLnn4P1osJp+U6LZ4O9Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 15, 2026 at 3:18 AM Ashutosh Bapat
<ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> wrote:
> I am mentioning the sections of SQL/PGQ standard which govern the
> behaviour here and showing you that the implementation is compliant
> with the standard. Maybe we missed adding comments mentioning the
> rationale. I have added that as a TODO
Obviously, this is your patch set, and you can proceed how you wish,
but I do not think that just adding some comments is going to be
nearly good enough. The inconsistencies between the rules that had to
hold at CREATE time and what had to hold at ALTER time are very
significant, and that's the sort of thing that usually turns out to
cause problems, as it did here. I don't think we have another DDL
command in the entire system where the gap is as large as what was the
case here, and I don't think a patch that doesn't think harder about
that topic is going to stay committed (or, hopefully, get committed).
--
Robert Haas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey Rachitskiy | 2026-09-16 20:54:31 | [PATCH] Catch croak during PL/Perl result conversion |
| Previous Message | Corey Huinker | 2026-09-16 20:45:26 | Re: [PG19][PATCH] Make postgres_fdw statistics import atomic |