Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
Cc: Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.
Date: 2012-05-24 18:45:51
Message-ID: CA+TgmoYk1gFvL7e9z+6tm70=nx0d-rN50tvqoZnCOGTYps31jg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, May 23, 2012 at 2:28 PM, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
> On Sat, Dec 31, 2011 at 10:34 PM, Simon Riggs <simon(at)2ndquadrant(dot)com> wrote:
>> Send new protocol keepalive messages to standby servers.
>> Allows streaming replication users to calculate transfer latency
>> and apply delay via internal functions. No external functions yet.
>
> Is there plan to implement such external functions before 9.2 release?
> If not, keepalive protocol seems to be almost useless because there is
> no use of it for a user and the increase in the number of packets might
> increase the replication performance overhead slightly. No?

Good point. IMHO, this shouldn't really have been committed like
this, but since it was, we had better fix it, either by reverting the
change or forcing an initdb to expose the functionality.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2012-05-24 18:52:05 Re: Re: [COMMITTERS] pgsql: Send new protocol keepalive messages to standby servers.
Previous Message Tom Lane 2012-05-24 17:56:32 pgsql: Fix array overrun in regex code.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2012-05-24 18:46:21 Re: "could not open relation with OID" errors after promoting the standby to master
Previous Message Robert Haas 2012-05-24 18:43:01 Re: 9.2beta1, parallel queries, ReleasePredicateLocks, CheckForSerializableConflictIn in the oprofile