| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Kuntal Ghosh <kuntalghosh(dot)2007(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POC: Cleaning up orphaned files using undo logs |
| Date: | 2019-05-02 13:30:34 |
| Message-ID: | CA+TgmoYjY2fB-DeLZk58622epfr4hNrXPMPaF7qkMrO687hFLQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 2, 2019 at 5:32 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
> Yeah, at least in this patch it looks silly. Actually, I added that
> index to make the qsort stable when execute_undo_action sorts them in
> block order. But, as part of this patch we don't have that processing
> so either we can remove this structure completely as you suggested but
> undo processing patch has to add that structure or we can just add
> comment that why we added this index field.
Well, the qsort comparator could compute the index as ptr - array_base
just like any other code, couldn't it?
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ibrar Ahmed | 2019-05-02 13:55:18 | Re: pgbench - add option to show actual builtin script code |
| Previous Message | Laurenz Albe | 2019-05-02 12:49:23 | Re: Bad canonicalization for dateranges with 'infinity' bounds |