Re: [COMMITTERS] pgsql: Add max_parallel_workers GUC.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add max_parallel_workers GUC.
Date: 2016-12-05 16:00:49
Message-ID: CA+TgmoYjWhSOx11ia5q1a_-hajCP=hx-aD_xyXbAfMOzAtmL-A@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Sat, Dec 3, 2016 at 11:43 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Dec 2, 2016, at 5:45 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Might work. We've had very bad luck with GUC variables with
>>> interdependent defaults, but maybe the user-visible knob could be a
>>> percentage of max_connections or something like that.
>
>> Seems like overkill. Let's just reduce the values a bit.
>
> Agreed. How about max_worker_processes = 8 as before, with
> max_parallel_workers of maybe 6? Or just set them both to 8.
> I'm not sure that the out-of-the-box configuration needs to
> leave backend slots locked down for non-parallel worker processes.
> Any such process would require manual configuration anyway no?

Sure, you'd have to arrange to load the relevant module somehow. It
would be nicer if we didn't have to require additional configuration
beyond that, but I'm not prepared to ask BF owners to reconfigure
their systems just for that marginal advantage, so I think we'll have
to live with this for now.

I pushed a commit backing out the increased default, which I
originally suggested. Mea culpa.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2016-12-05 16:04:19 pgsql: Assorted documentation improvements for max_parallel_workers.
Previous Message Robert Haas 2016-12-05 15:58:47 pgsql: Reduce the default for max_worker_processes back to 8.

Browse pgsql-hackers by date

  From Date Subject
Next Message Pantelis Theodosiou 2016-12-05 16:04:30 Re: missing optimization - column <> column
Previous Message Andrew Dunstan 2016-12-05 15:56:00 Time to retire Windows XP buildfarm host?