Re: pgsql: Avoid coercing a whole-row variable that is already coerced

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pgsql: Avoid coercing a whole-row variable that is already coerced
Date: 2017-10-13 16:21:13
Message-ID: CA+TgmoYj8ynJOqnDT6ECC2uK7MT-zjj=_x8q_EJ2VnR1QG57aQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 13, 2017 at 5:57 AM, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com> wrote:
> One thing we can do is : instead of calling
> map_variable_attnos_mutator(), convert the var inside the if block for
> "if (IsA(node, ConvertRowtypeExpr))". Please check the attached patch.
> There, I have avoided coerced_var context variable.

Tom, is this more like what you have in mind?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-10-13 16:34:11 Re: Aggregate transition state merging vs. hypothetical set functions
Previous Message Alexander Korotkov 2017-10-13 15:58:55 Re: Predicate Locks for writes?