| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Write Ahead Logging for Hash Indexes |
| Date: | 2017-03-10 03:19:52 |
| Message-ID: | CA+TgmoYit4Kn8TFXMLzoZSvKK9OXDjU8pMap9phg-vfC5hcxzQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 9, 2017 at 9:34 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Do we really need to set LSN on this page (or mark it dirty), if so
> why? Are you worried about restoration of FPI or something else?
I haven't thought through all of the possible consequences and am a
bit to tired to do so just now, but doesn't it seem rather risky to
invent a whole new way of using these xlog functions?
src/backend/access/transam/README describes how to do write-ahead
logging properly, and neither MarkBufferDirty() nor PageSetLSN() is
described as an optional step.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-03-10 03:24:45 | Re: Upgrading postmaster's log messages about bind/listen errors |
| Previous Message | Peter Geoghegan | 2017-03-10 03:12:28 | Re: amcheck (B-Tree integrity checking tool) |