| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |
| Date: | 2016-02-12 17:37:35 |
| Message-ID: | CA+TgmoYgLeetj=pQQ1oMj5KyqD4-pf5tcPbiSjQSooyw2Qa=ZQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Mon, Feb 8, 2016 at 4:18 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I'm not really a fan. I'd rather change existing callers to add a
> 'flags' bitmask argument. Right now there can't really be XLogInserts()
> in extension code, so that's pretty ok to change.
Yeah, but to what benefit? You're just turning a smaller patch into a
bigger one and requiring churning a bunch of code that wouldn't
otherwise need to be touched. I think Michael has a good point.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2016-02-12 17:56:35 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |
| Previous Message | Teodor Sigaev | 2016-02-12 16:44:22 | Re: BUG #13440: unaccent does not remove all diacritics |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2016-02-12 17:40:43 | Re: Fuzzy substring searching with the pg_trgm extension |
| Previous Message | Konstantin Knizhnik | 2016-02-12 17:23:29 | Re: Clock with Adaptive Replacement |