| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Group clear xid can leak semaphore count |
| Date: | 2017-01-05 21:57:11 |
| Message-ID: | CA+TgmoYfJ6td1=Brd3m+HPme0XAQ=YHrryO5J6xm2TOOSUAP6A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Jan 5, 2017 at 4:48 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> I think we have run into this kind of issue before. I wonder if
>> there's any way to insert some kind of a guard - e.g. detect at
>> backend startup time that the semaphore has a non-zero value and fix
>> it, issuing a warning along the way... maybe something like:
>
> See the PGSemaphoreReset near the end of InitProcess.
Oh ho. So the worst consequence of this is a backend-lifetime leak,
not a cluster-lifetime leak. That's good, at least.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-01-05 22:02:45 | Re: [COMMITTERS] pgsql: Fix possible crash reading pg_stat_activity. |
| Previous Message | Michael Banck | 2017-01-05 21:56:23 | Re: Replication/backup defaults |