Re: [PATCH] add long options to pgbench (submission 1)

On Tue, Jun 25, 2013 at 3:09 PM, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> wrote:
>> I think --quiet-log should be spelled --quiet.
>
> ISTM that --quiet usually means "not verbose on stdout", so I added log
> because this was specific to the log output, and that there may be a need
> for a --quiet option for stdout at some time.

The output that is quieted by -q is not the log output produced by
--log; it's the regular progress output on stdout/stderr.

So I changed that, and committed this, with some further cosmetic
changes. I made the formatting of the help message more like psql's
help message, including adjusting pgbench to start the description of
each option in the same column that psql does. This got rid of a lot
of line breaks and IMHO makes the output of pgbench --help quite a bit
more readable. I made stylistic adjustments to the documentation
portion of the patch as well, again to match the markup used for psql.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company