Re: Inconsistency in Output function of MergeJoin

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Inconsistency in Output function of MergeJoin
Date: 2015-09-23 14:52:58
Message-ID: CA+TgmoYc5Tgs71pMuo7vBWUfg7MZjsRh84qoWM3XRkG1Eq-dwQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Sep 23, 2015 at 5:56 AM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> While working on read functions for plan nodes (required for
> parallelism), it has been observed [1] by KaiGai and separately
> by me that function _outMergeJoin(), appends boolean in a
> slightly different way as compare to other out functions like
> _outSort(). Is there a reason of doing so which is is not apparent
> from code or comments?
>
> Attached patch makes _outMergeJoin() consistent with other _out
> functions which appends boolean to string.

Seems right to me. I'll go commit this.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-09-23 14:59:01 Re: unclear about row-level security USING vs. CHECK
Previous Message Robert Haas 2015-09-23 14:48:07 Re: [PATCH] Refactoring of LWLock tranches