Re: tableam vs. TOAST

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Prabhat Sahu <prabhat(dot)sahu(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: tableam vs. TOAST
Date: 2019-10-04 18:32:51
Message-ID: CA+TgmoYbrSz13Mn+2=6bQvLju-tRXB9FAA4GQpqdZXro80Expw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Sep 6, 2019 at 10:59 AM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Thu, Sep 5, 2019 at 4:07 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Yea, makes sense to me.
>
> OK, done. Here's the remaining patches again, with a slight update to
> the renaming patch (now 0002). In the last version, I renamed
> toast_insert_or_update to heap_toast_insert_or_update but did not
> rename toast_delete to heap_toast_delete. Actually, I'm not seeing
> any particular reason not to go ahead and push the renaming patch at
> this point also.

And, hearing no objections, done.

Here's the last patch back, rebased over that renaming. Although I
think that Andres (and Tom) are probably right that there's room for
improvement here, I currently don't see a way around the issues I
wrote about in http://postgr.es/m/CA+Tgmoa0zFcaCpOJCsSpOLLGpzTVfSyvcVB-USS8YoKzMO51Yw@mail.gmail.com
-- so not quite sure where to go next. Hopefully Andres or someone
else will give me a quick whack with the cluebat if I'm missing
something obvious.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
v7-0001-Allow-TOAST-tables-to-be-implemented-using-table-.patch application/octet-stream 36.9 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2019-10-04 18:37:42 Re: Memory Accounting
Previous Message Chapman Flack 2019-10-04 18:05:41 Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays