| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Date: | 2015-09-10 18:00:01 |
| Message-ID: | CA+TgmoYbOSiUiBnmdi-EePGNM4qgGbctqTCsfmxuxveHh+bYUA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Sep 9, 2015 at 11:49 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> - errdetail("Could not rename \"%s\" to \"%s\": %m.",
> + errdetail("\"%s\" could not be renamed to \"%s\": %m.",
>
> Is there any reason to change this message?
> I think you have changed this message to make it somewhat similar with
> the new message we are planning to use in this function, but I don't see
> that as compelling reason to change this message.
The old message better follows the guidelines. See section 51.3.7:
Avoid Passive Voice. The old message is what's called
"telegram-style", with PostgreSQL itself as the implicit subject. The
proposed replacement is just the regular old passive voice.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-09-10 19:52:15 | Re: Re: [COMMITTERS] pgsql: Map basebackup tablespaces using a tablespace_map file |
| Previous Message | Tom Lane | 2015-09-10 14:27:13 | pgsql: Fix setrefs.c comment properly. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | chenhj | 2015-09-10 18:07:37 | Re: A better translation version of Chinese forpsql/po/zh_CN.po file |
| Previous Message | Jeff Janes | 2015-09-10 17:16:38 | Re: [PATCH] SQL function to report log message |