| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Erik Rijkers <er(at)xs4all(dot)nl>, Jeff Davis <pgsql(at)j-davis(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: allowing for control over SET ROLE |
| Date: | 2022-11-21 15:45:53 |
| Message-ID: | CA+TgmoYambdoW7tYvapvGct7mgge+zTGtwbi5wm2HYe8C=OTkA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Nov 19, 2022 at 1:00 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Nov 18, 2022 at 04:19:15PM -0500, Robert Haas wrote:
> > Fixed that, and the other mistake Álvaro spotted, and also bumped
> > catversion because I forgot that earlier.
>
> I was looking at this code yesterday, to see today that psql's
> completion should be completed with this new clause, similary to ADMIN
> and INHERIT.
Seems like a good idea but I'm not sure about this hunk:
TailMatches("GRANT|REVOKE", "ALTER", "SYSTEM") ||
- TailMatches("REVOKE", "GRANT", "OPTION", "FOR", "ALTER", "SYSTEM"))
+ TailMatches("REVOKE", "GRANT", "OPTION", "FOR", "ALTER", "SYSTEM") ||
+ TailMatches("REVOKE", "GRANT", "OPTION", "FOR", "SET"))
That might be a correct change for other reasons, but it doesn't seem
related to this patch. The rest looks good.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-11-21 15:51:05 | pgsql: Prevent instability in contrib/pageinspect's regression test. |
| Previous Message | Robert Haas | 2022-11-21 15:35:46 | Re: Damage control for planner's get_actual_variable_endpoint() runaway |