Re: [COMMITTERS] pgsql: Remove sanity test in XRecOffIsValid.

On Mon, Jun 25, 2012 at 12:35 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>> Remove sanity test in XRecOffIsValid.
>
>> Commit 061e7efb1b4c5b8a5d02122b7780531b8d5bf23d changed the rules
>> for splitting xlog records across pages, but neglected to update this
>> test.  It's possible that there's some better action here than just
>> removing the test completely, but this at least appears to get some
>> of the things that are currently broken (like initdb on MacOS X)
>> working again.
>
> Offhand, I'm wondering why this macro doesn't include a MAXALIGN test.
> If it did, I don't think that the upper-limit test would have any
> use anymore.

Yeah, I wondered that, too, but wasn't sure enough about what the real
alignment requirements were to do it myself.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company