Re: aborting a non-speculative insertion

On Tue, Jun 11, 2019 at 12:06 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > This is relevant to my little project to make the TOAST logic reusable
> > by other AMs, because the comments in tableam.h suggest you can only
> > complete a speculative insertion if you've previously performed one.
> > If we allow any AM to be used to implement a TOAST table, then it
> > needs to be documented that such AMs have to cope with this kind of
> > case.
>
> Hm - you're thinking of making the case of toast AM and main AM being
> different working? I'm not sure I'd otherwise expect to again go through
> the AM, although I'm not sure about that.

I was, but I think we have the same requirement even if we don't,
because detoasting a datum from anywhere goes through a common code
path.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company