Re: pgsql: walreceiver uses a temporary replication slot by default

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-committers <pgsql-committers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: walreceiver uses a temporary replication slot by default
Date: 2020-01-23 20:49:37
Message-ID: CA+TgmoYYsp+uUo74tzboTBOL3WtQ4QJY6JU1wHWJG59UFNaDgg@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Tue, Jan 14, 2020 at 8:57 AM Peter Eisentraut <peter(at)eisentraut(dot)org> wrote:
> walreceiver uses a temporary replication slot by default
>
> If no permanent replication slot is configured using
> primary_slot_name, the walreceiver now creates and uses a temporary
> replication slot. A new setting wal_receiver_create_temp_slot can be
> used to disable this behavior, for example, if the remote instance is
> out of replication slots.
>
> Reviewed-by: Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>
> Discussion: https://www.postgresql.org/message-id/CA%2Bfd4k4dM0iEPLxyVyme2RAFsn8SUgrNtBJOu81YqTY4V%2BnqZA%40mail.gmail.com

Neither the commit message for this patch nor any of the comments in
the patch seem to explain why this is a desirable change.

I assume that's probably discussed on the thread that is linked here,
but you shouldn't have to dig through the discussion thread to figure
out what the benefits of a change like this are.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-01-23 21:15:59 pgsql: Fix an oversight in commit 4c70098ff.
Previous Message Tom Lane 2020-01-23 18:42:34 pgsql: Clean up formatting.c's logic for matching constant strings.

Browse pgsql-hackers by date

  From Date Subject
Next Message Mark Dilger 2020-01-23 21:05:10 Re: making the backend's json parser work in frontend code
Previous Message Robert Haas 2020-01-23 20:47:10 Re: [Proposal] Global temporary tables