Re: pg_*_advice: tsv load failure, etc.

On Mon, Oct 5, 2026 at 1:01 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On top of all that, I'm still looking into one more problem discovered
> along the way as well, but I'm not ready to write about that, yet.

Here's v7, adding one more patch to fix the "one more problem"
mentioned, inserted into the sequences as 0003. Note that this breaks
ABI compatibility, but I nevertheless plan to back-patch to v19. cc:
rmt, in case they wish to weigh in.

0001-0003 all fix related deficiencies in child_append_relid_sets
handling. 0001 fixes the failure to fix up the RTIs stored in that
field at setrefs time; 0002 fixes pg_plan_advice's failure to set the
scan type properly for scans derived from child_append_relid_sets;
0003 fixes loss of child_append_relid_sets when (Merge)Append nodes
bearing them are subsequently elided. All of these solve problems
related to plan advice and partitioning, especially multi-level
partitioning, which I appear to have significantly under-tested. 0004
is unrelated to child_append_relid_sets, but still related to
partitioning: NO_GATHER can be left out of plan advice where it's
actually needed. And 0005 still fixes
JOIN_ORDER((whole_group_multiply_delimited)) scenarios.

Sorry for all the mistakes. :-(

--
Robert Haas
Databricks