Re: pgsql: Compute XID horizon for page level index vacuum on primary.

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Compute XID horizon for page level index vacuum on primary.
Date: 2019-05-01 17:10:40
Message-ID: CA+TgmoYX_NpujURawaV-UH6HLSCsdjEw8-qxQ_DKM22BNRqYZw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On Wed, May 1, 2019 at 12:50 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Not strongly enough to argue about it very hard. The current behavior
> > is a little weird, but it's a long way from being the weirdest thing
> > we ship, and it appears that we have no tangible evidence that it
> > causes a problem in practice.
>
> I think there's nothing that fails to suck about a hardwired "+ 10".

It avoids a performance regression without adding another GUC.

That may not be enough reason to keep it like that, but it is one
thing that does fail to suck.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2019-05-02 14:19:31 pgsql: Fix some problems with VACUUM (INDEX_CLEANUP FALSE).
Previous Message Tom Lane 2019-05-01 16:50:16 Re: pgsql: Compute XID horizon for page level index vacuum on primary.

Browse pgsql-hackers by date

  From Date Subject
Next Message Alexander Kukushkin 2019-05-01 17:12:52 Re: walsender vs. XLogBackgroundFlush during shutdown
Previous Message Robert Haas 2019-05-01 17:09:07 Re: hyrax vs. RelationBuildPartitionDesc