| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CustomScan in a larger structure (RE: CustomScan support on readfuncs.c) |
| Date: | 2016-02-11 04:26:20 |
| Message-ID: | CA+TgmoYX++pMvO5pkkA9WeYTMQxcznduPgJwAOuOiw40EFhWOg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Feb 10, 2016 at 1:25 AM, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com> wrote:
> It is pretty good!
>
> The attached patch (primary one) implements the above idea.
>
> Now ExtensibleNode works as a basis structure of data container,
> regardless of CustomScan and ForeignScan.
> Also, fdw_private and custom_private are de-defined to Node * type
> from List * type. It affected to a few FDW APIs.
I extracted the subset of this that just creates the extensible node
framework and did some cleanup - the result is attached. I will
commit this if nobody objects.
I think the part about whacking around the FDW API is a little more
potentially objectionable to others, so I want to hold off doing that
unless a few more people chime in with +1. Perhaps we could start a
new thread to talk about that specific idea. This is useful even
without that, though.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| Attachment | Content-Type | Size |
|---|---|---|
| extensible-node-subset.patch | application/x-patch | 13.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chapman Flack | 2016-02-11 04:51:28 | Re: Mac OS: invalid byte sequence for encoding "UTF8" |
| Previous Message | Amit Kapila | 2016-02-11 03:55:30 | Re: Re: BUG #13685: Archiving while idle every archive_timeout with wal_level hot_standby |