| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Haibo Yan <tristan(dot)yim(at)gmail(dot)com> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, jian he <jian(dot)universality(at)gmail(dot)com>, Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>, Vik Fearing <vik(at)postgresfriends(dot)org>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: implement CAST(expr AS type FORMAT 'template') |
| Date: | 2026-06-29 18:13:59 |
| Message-ID: | CA+TgmoYW4_Ze_iT-o64VuFGqpm48hh=4dyZJwqiWfRPDTW+L+g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 29, 2026 at 1:20 AM Haibo Yan <tristan(dot)yim(at)gmail(dot)com> wrote:
> I have attached the full patch series for review. Comments are welcome.
This looks good!
I haven't done a detailed review, but I skimmed over all of the
patches and I like the direction. I think we should consider calling
it a "format cast" instead of a "formatter". It would avoid needing to
make "formatter" a parser keyword.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2026-06-29 18:17:02 | Re: use of SPI by postgresImportForeignStatistics |
| Previous Message | Álvaro Herrera | 2026-06-29 17:16:59 | Re: Differential Code Coverage report for Postgres |