Re: block-level incremental backup

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Cc: Jeevan Ladhe <jeevan(dot)ladhe(at)enterprisedb(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: block-level incremental backup
Date: 2019-09-03 12:59:53
Message-ID: CA+TgmoYVz1WFfLT7BRJaVzy07szNUw7CCYJQ3r=ZyXqcxingyQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sat, Aug 31, 2019 at 3:41 PM Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com> wrote:
> Are we using any tar library in pg_basebackup.c? We already have the capability
> in pg_basebackup to do that.

I think pg_basebackup is using homebrew code to generate tar files,
but I'm reluctant to do that for reading tar files. For generating a
file, you can always emit the newest and "best" tar format, but for
reading a file, you probably want to be prepared for older or cruftier
variants. Maybe not -- I'm not super-familiar with the tar on-disk
format. But I think there must be a reason why tar libraries exist,
and I don't want to write a new one.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2019-09-03 13:22:30 Locking a row with KEY SHARE NOWAIT blocks
Previous Message Tomáš Záluský 2019-09-03 12:56:02 unexpected rowlock mode when trigger is on the table