| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: non-exclusive backup cleanup is mildly broken |
| Date: | 2019-12-19 14:08:16 |
| Message-ID: | CA+TgmoYVFfJNM6znJyxWtVhf750wajgfvfHthc017GnkEuYtxQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Dec 17, 2019 at 3:48 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Oh, scratch that --- looking closer, I see that the only two use-cases in
> the patched code are via before_shmem_exit and PG_ENSURE_ERROR_CLEANUP,
> and both of those require a function with the signature of an on_exit
> callback.
Yeah, that's why I was surprised that you wanted shim functions.
> So there's no need for a separate wrapper because this isn't
> going to be called any other way. I still recommend amending the
> comment to explain why it has this signature, though.
Done, and committed.
Thanks,
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2019-12-19 14:20:30 | Re: [HACKERS] [PATCH] Generic type subscripting |
| Previous Message | Robert Haas | 2019-12-19 13:47:57 | Re: [HACKERS] Block level parallel vacuum |