Re: phrase search TS_phrase_execute code readability patch

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: phrase search TS_phrase_execute code readability patch
Date: 2016-08-11 03:25:55
Message-ID: CA+TgmoYUisVETnoVPL_ynE_d6WTKfui1jtqN_mm51B_EvAaeCw@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Aug 9, 2016 at 3:35 PM, David G. Johnston
<david(dot)g(dot)johnston(at)gmail(dot)com> wrote:
> I don't follow why LposStart is needed so I removed it...

That doesn't seem very reasonable.

> Not compiled or in any way tested...

Please do not bother submitting patches that you aren't prepared to
compile and test.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kisung Kim 2016-08-11 04:08:11 Re: Btree Index on PostgreSQL and Wiredtiger (MongoDB3.2)
Previous Message Robert Haas 2016-08-11 02:50:40 Re: No longer possible to query catalogs for index capabilities?