| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Dave Page <dpage(at)pgadmin(dot)org>, Peter Geoghegan <pg(at)heroku(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, "Brightwell, Adam" <adam(dot)brightwell(at)crunchydatasolutions(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Craig Ringer <craig(at)2ndquadrant(dot)com>, Yeb Havinga <yeb(dot)havinga(at)portavita(dot)nl> |
| Subject: | Re: RLS feature has been committed |
| Date: | 2014-09-23 13:09:46 |
| Message-ID: | CA+TgmoYUJj-Hbnb0wUO6+4VuCAQeJHDM1vZoeY1_ULsupra4UA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 23, 2014 at 9:00 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> I think it's obvious that a committer doesn't need to wait till some
> later commitfest to commit patches that have since gotten enough review
> or are uncontroversial. Neither is the case here.
Right. I mean, the occasionally-floated notion that committers can't
commit things when there's no CommitFest ongoing is obviously flat
wrong, as a quick look at the commit log will demonstrate.
On the flip side, it's unreasonable to expect that as soon as a
committer posts 7000-line patch, everyone who possibly has an
objection to that patch will drop everything that they are doing to
object to anything they don't like about it. It can easily take a
week to review such a patch thoroughly even if you start the minute it
hits the list.
Many committers, including me, have held off on committing patches for
many months to make sure that the community got time to review them,
even though nobody explicitly objected. This patch was committed much
faster than that and over an explicit objection.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2014-09-23 13:13:03 | Re: Review of GetUserId() Usage |
| Previous Message | Andres Freund | 2014-09-23 13:09:04 | Re: RLS feature has been committed |