| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Jerry Sievers <gsievers19(at)comcast(dot)net>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SegFault on 9.6.14 |
| Date: | 2019-09-12 13:35:15 |
| Message-ID: | CA+TgmoYUC6QDUqXbmxnwq1qUW_fodQFHbhn0puKJSUSPM+ndcA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Sep 12, 2019 at 8:55 AM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> Robert, Thomas, do you have any more suggestions related to this. I
> am planning to commit the above-discussed patch (Forbid Limit node to
> shutdown resources.) coming Monday, so that at least the reported
> problem got fixed.
I think that your commit message isn't very clear about what the
actual issue is. And the patch itself doesn't add any comments or
anything to try to clear it up. So I wouldn't favor committing it in
this form.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2019-09-12 13:39:34 | Re: Misleading comment in tuplesort_set_bound |
| Previous Message | Tom Lane | 2019-09-12 13:32:54 | Re: Close stdout and stderr in syslogger |