Re: psql output change in 9.4

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: psql output change in 9.4
Date: 2014-08-11 18:28:45
Message-ID: CA+TgmoYTj2zWoC=aSQFDKGsCi2gfezfdhkakxtzXEt85vUnJ+w@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Aug 11, 2014 at 1:52 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>> On Fri, Aug 8, 2014 at 9:34 PM, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>>> What is the point of that change?
>
>> I think the output could justly be criticized for making it
>> insufficiently clear that the parenthesized text is, in fact, the name
>> of the pset parameter.
>
> Quite; that wasn't apparent to me either.
>
>> We could write something like:
>> Border style (parameter "border") is 1.
>
> How about
>
> Border style (\pset border) is 1.

That would look just fine as a response to \a or \x, but I'm not sure
it would look as good as a response to \pset, which prints out that
line for every parameter ("why does every line say \pset when the
command I just typed is \pset?"). However, I can certainly live with
it if others prefer that to what I suggested.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-08-11 19:07:44 Re: jsonb format is pessimal for toast compression
Previous Message Robert Haas 2014-08-11 18:25:22 Re: bad estimation together with large work_mem generates terrible slow hash joins