Re: Removing #include "postgres.h" from a couple of headers

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Removing #include "postgres.h" from a couple of headers
Date: 2017-03-08 13:25:27
Message-ID: CA+TgmoYRE+dPtV7PbCSOZcoGjTpNfGd-dfrHhPbKAJo+Dxv8KQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 8, 2017 at 3:55 AM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> Over in another thread it was pointed out that a patch I submitted
> broke a project rule by including "postgres.h" in a header. Here is a
> patch to remove it from dsa.h where I made the same mistake, and also
> a case I found in bufmask.h by grepping.

Committed.

> There are also instances in regcustom.h and snowball's header.h -- are
> those special cases?

I will leave this question to someone wiser (or more self-assured) than I.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2017-03-08 13:27:30 Re: Skip all-visible pages during second HeapScan of CIC
Previous Message Stephen Frost 2017-03-08 13:22:22 Re: Skip all-visible pages during second HeapScan of CIC