Re: [HACKERS] Concurrent ALTER SEQUENCE RESTART Regression

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com>, Jason Petersen <jason(at)citusdata(dot)com>, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>
Subject: Re: [HACKERS] Concurrent ALTER SEQUENCE RESTART Regression
Date: 2017-05-24 14:24:19
Message-ID: CA+TgmoYQ_RAJbyupefJsg2W2P4vjKfCuLHyuqOuX_54SNCA9DQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Wed, May 24, 2017 at 9:04 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> At the very least we'll have to error out. That's still not nice usability wise, but it sure beats returning flat out wrong values.

I'm not sure. That seems like it might often be worse. Now you need
manual intervention before anything even has a hope of working.

> I suspect that the proper fix would be to use a different relfilenode after ddl, when changing the seq file itself (I.e. setval and restart). That seems like it'd be architecturally more appropriate, but also some work.

I can see some advantages to that, but it seems far too late to think
about doing that in v10.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2017-05-24 14:32:40 Re: [HACKERS] Concurrent ALTER SEQUENCE RESTART Regression
Previous Message Florian Gossin 2017-05-24 14:18:12 Can't restore view with pg_restore

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2017-05-24 14:29:46 Re: Error-like LOG when connecting with SSL for password authentication
Previous Message Nick Dro 2017-05-24 14:00:20 Error log for psql (uploading backup) in PostgreSQL 9.3.17