| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: A new message seems missing a punctuation |
| Date: | 2024-02-19 05:01:33 |
| Message-ID: | CA+TgmoYPi8dMZqYd8oZXfBFQY5DjCmu4ZbrKbCSRWkoyz1ytNg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Feb 19, 2024 at 10:10 AM Kyotaro Horiguchi
<horikyota(dot)ntt(at)gmail(dot)com> wrote:
> A recent commit (7a424ece48) added the following message:
>
> > could not sync slot information as remote slot precedes local slot:
> > remote slot "%s": LSN (%X/%X), catalog xmin (%u) local slot: LSN
> > (%X/%X), catalog xmin (%u)
>
> Since it is a bit overloaded but doesn't have a separator between
> "catalog xmin (%u)" and "local slot:", it is somewhat cluttered. Don't
> we need something, for example a semicolon there to improve
> readability and reduce clutter?
I think maybe we should even revise the message even more. In most
places we do not just print out a whole bunch of values, but use a
sentence to connect them.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrei Lepikhov | 2024-02-19 05:24:09 | Re: Removing unneeded self joins |
| Previous Message | Kyotaro Horiguchi | 2024-02-19 04:40:15 | A new message seems missing a punctuation |