| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: replacing role-level NOINHERIT with a grant-level option |
| Date: | 2022-08-30 02:16:26 |
| Message-ID: | CA+TgmoYKsLrqwBarzqorh5b-xvDdhve=uhk5fNfd0M0sRnPh_A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 29, 2022 at 6:04 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
> On Mon, Aug 29, 2022 at 03:38:57PM -0400, Robert Haas wrote:
> > Here is a patch to rearrange the logic slightly and also add a test
> > case memorializing the intended behavior. Without this change, the
> > regression test included in the patch fails like this:
> >
> > ERROR: no possible grantors
> >
> > ...which is never supposed to happen.
>
> The grantor column in the expected test output refers to "rhaas", so I
> imagine the test only passes on your machines. Should we create a new
> grantor role for this test?
That's the second time I've made that exact mistake *on this thread*.
I'm super good at this, I promise.
I'll figure out a fix tomorrow when I'm less tired. Thanks for catching it.
--
Robert Haas
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2022-08-30 02:24:10 | RE: Data is copied twice when specifying both child and parent table in publication |
| Previous Message | Tomas Vondra | 2022-08-30 02:12:35 | Re: Reducing the chunk header sizes on all memory context types |