| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, amul sul <sulamul(at)gmail(dot)com> |
| Subject: | Re: pgsql: Move tar detection and compression logic to common. |
| Date: | 2026-07-22 16:23:02 |
| Message-ID: | CA+TgmoYJY8FkoeYKGF_YF1S6uOK7fd0Bd3zrw0XY_oZXbmVFpQ@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Fri, Mar 20, 2026 at 3:32 PM Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
> Move tar detection and compression logic to common.
>
> Consolidate tar archive identification and compression-type detection
> logic into a shared location. Currently used by pg_basebackup and
> pg_verifybackup, this functionality is also required for upcoming
> pg_waldump enhancements.
>
> https://git.postgresql.org/pg/commitdiff/c8a350a439826267186c187dbfbf1f839f7521aa
Unfortunately, this commit not only consolidated the logic but also
changed the behavior at both of the then-existing call sites for the
worse.
I attach a patch to undo those behavior changes, which I intend to
commit and back-patch to v19.
--
Robert Haas
EDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Undo-inadvertent-loosening-of-archive-filename-ch.patch | application/octet-stream | 6.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2026-07-22 19:28:02 | Re: pgsql: Move tar detection and compression logic to common. |
| Previous Message | Robert Haas | 2026-07-22 13:09:52 | pgsql: walsummarizer: Guard against WAL files whose tail ends are not v |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-07-22 16:24:48 | Re: [PATCH] Batched clock sweep to reduce cross-socket atomic contention |
| Previous Message | Peter Eisentraut | 2026-07-22 16:15:35 | Re: [PATCH] Rebuild CHECK constraints after generated column SET EXPRESSION |