Re: json/jsonb cleanup + FmgrInfo caching

From: Robert Haas <robertmhaas(at)gmail(dot)com>
To: Manu <manuelreyesbravo(at)gmail(dot)com>
Cc: jian he <jian(dot)universality(at)gmail(dot)com>, shihao zhong <zhong950419(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net>
Subject: Re: json/jsonb cleanup + FmgrInfo caching
Date: 2026-11-03 14:58:45
Message-ID: CA+TgmoYJMxeY2XoQ88qHgi2NCA2LbQd=aoVwcOAPLq3KZ22DKQ@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Oct 23, 2026 at 7:28 PM Manu <manuelreyesbravo(at)gmail(dot)com> wrote:
> I tested v4 on master and REL_19_STABLE. It applies cleanly, builds
> without warnings, and make check passes on both. My range-over-enum
> case is rejected now, and so are your myr demo and shihao's float8 and
> float4 case on master. int4range and int4multirange are still
> accepted. v4 covers the range case, so my diff from upthread is no
> longer needed.

Hi,

I think basically what's being alleged here is that Andrew's commit
ecd9288624a1582a732cf86ac5a01475a1ce7815, patch by Jian He, is broken.
What I think should have happened is a new thread about that problem
specifically, or perhaps a continuation of the original thread for
that commit. Either way, that thread should have been added to the
open items list. Instead, because I reported a portion of the problem,
without realizing it was new in v19, this thread has gotten hijacked
to talk about the v19 regression vs. v18 and prior, rather than about
my patches. v4-0001 copies my commit message from v1-0002 even though
it's not the same patch at all, and nothing's been added to the open
items list, so I'm not sure that Andrew even knows that there's a
potential problem here in need of urgent correction.

Jian and Manu, please move this discussion to an appropriate new or
existing thread, fix the patch's commit message to clearly describe
the problem and the solution, and write an email to support the patch
submission that clearly explains everything relevant, including the
history. Also, add it to the open items list ASAP.

Andrew, please take note.

Once whatever needs fixing here is fixed, I'll rebase these patches.

Thanks,

--
Robert Haas
Databricks

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Burd 2026-11-03 15:09:00 Re: Hash index inserts serialise on the metapage tuple counter
Previous Message Bruce Momjian 2026-11-03 14:58:22 Re: First draft of PG 19 release notes