| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
| Cc: | Jakub Glapa <jakub(dot)glapa(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Fabio Isabettini <fisabettini(at)voipfuture(dot)com>, Arne Roland <A(dot)Roland(at)index(dot)de>, Sand Stone <sand(dot)m(dot)stone(at)gmail(dot)com>, Rick Otten <rottenwindfish(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: dsa_allocate() faliure |
| Date: | 2019-02-10 06:26:14 |
| Message-ID: | CA+TgmoYHc6_oLdE5fSgtmTUouJvTGTOSOcHfFJoyvTMi3FeQ3Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-performance |
On Sun, Feb 10, 2019 at 1:55 AM Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> Bleugh. Yeah. What I said before wasn't quite right. The value
> returned by FreePageManagerPutInternal() is actually correct at the
> moment it is returned, but it ceases to be correct immediately
> afterwards if the following call to FreePageBtreeCleanup() happens to
> reduce the size of that particular span. The problem is that we
> clobber fpm->contiguous_pages with the earlier (and by now incorrect)
> value that we were holding in a local variable.
Yeah, I had similar bugs to that during the initial development work I
did on freepage.c, and that's why I got rid of some lazy recomputation
thing that I had tried at some point. The version that got committed
brought that back again, but possibly it's got the same kind of
problem.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-02-10 06:40:52 | Re: dsa_allocate() faliure |
| Previous Message | Konstantin Knizhnik | 2019-02-10 06:12:13 | Re: libpq compression |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-02-10 06:40:52 | Re: dsa_allocate() faliure |
| Previous Message | Ricardo Martin Gomez | 2019-02-10 00:23:59 | Re: slow to run query 5000 times |