| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] parallel.c oblivion of worker-startup failures |
| Date: | 2018-01-23 16:15:29 |
| Message-ID: | CA+TgmoYHJ2UTP=pgz6Na6r_DVrKqvQip-1qSMurdTU9QwshUWA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 22, 2018 at 10:56 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> It does turn such cases into error but only at the end when someone
> calls WaitForParallelWorkersToFinish. If one tries to rely on it at
> any other time, it won't work as I think is the case for Parallel
> Create Index where Peter G. is trying to use it differently. I am not
> 100% sure whether Parallel Create index has this symptom as I have not
> tried it with that patch, but I and Peter are trying to figure that
> out.
OK. I've committed this patch and back-patched it to 9.6.
Back-patching to 9.5 didn't looks simple because nworkers_launched
doesn't exist on that branch, and it doesn't matter very much anyway
since the infrastructure has no in-core users in 9.5.
I'll respond to the other thread about the issues specific to parallel
CREATE INDEX.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2018-01-23 16:24:00 | Re: pgsql: Move handling of database properties from pg_dumpall into pg_dum |
| Previous Message | Константин Евтеев | 2018-01-23 16:09:28 | Re: Invalidation pg catalog cache in trigger functions |