| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
| Cc: | "-ha >> PostgreSQL-development" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: CreateEventTrigStmt copy fix |
| Date: | 2014-09-22 20:20:23 |
| Message-ID: | CA+TgmoYFWV8U00bO3Zhsr2kJZY=jZmYdHVqagDNztz+ogvrqpg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Sep 19, 2014 at 12:09 PM, Petr Jelinek <petr(at)2ndquadrant(dot)com> wrote:
> I was trying to create event trigger inside DO statement inside an extension
> SQL script and noticed that the new event trigger has empty evtevent field.
> After some tinkering with gdb I found out that the memory context switches
> sometimes clear the eventname in CreateEventTrigStmt struct. The reason for
> this is that _copyCreateEventTrigStmt uses COPY_SCALAR_FIELD on eventname
> instead of COPY_STRING_FIELD.
>
> Attached patch fixes this and also the same issue in
> _equalCreateEventTrigStmt.
>
> This should be back-patched to 9.3 where event triggers were introduced.
Done, thanks.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2014-09-22 20:24:26 | Re: jsonb format is pessimal for toast compression |
| Previous Message | Robert Haas | 2014-09-22 19:59:18 | Re: Options OUTPUT_PLUGIN_* controlling format are confusing (Was: Misleading error message in logical decoding) |